Skip to content

[OGUI-689] Tree refresh should keep state of opened objects #3235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graduta merged 15 commits into from
Jan 6, 2026
Merged

[OGUI-689] Tree refresh should keep state of opened objects #3235

graduta merged 15 commits into from
Jan 6, 2026
+180 −22

Conversation

@hehoon
Copy link
Collaborator

@hehoon hehoon commented Dec 13, 2025 •
edited by graduta
Loading

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

Changes:

  • The tree on the object tree page now persists its expanded node state in local storage.

Note:

  • The estimated storage size (in bytes) is approximately: A * (N + 7) * 2
    • A is the number of expanded (opened) nodes
    • N is the average character length of expanded (opened) node names
  • The storing of tree node states will break if two identical names are stored directly under the same parent. This limitation already existed in the previous implementation and is unchanged by the current persistence mechanism.
  • A temporary workaround was added to handle local storage resets in tests, since some tests are not fully isolated and depend on shared state. Ideally, all tests should be isolated, with local storage and page state fully reset between each test.

@hehoon hehoon self-assigned this Dec 13, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 15, 2025
View reviewed changes
@hehoon hehoon marked this pull request as ready for review December 15, 2025 13:48
@hehoon hehoon requested a review from graduta as a code owner December 15, 2025 13:48
graduta
graduta requested changes Jan 5, 2026
View reviewed changes
Copy link
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The features works very well, good job!

I believe there is one case that you missed though. If the user clicks on the Collapse all button from the header of the page, the state of the objects is not saved, so a refresh of the page will reopen the previous state

@hehoon
Copy link
Collaborator Author

hehoon commented Jan 5, 2026 •
edited
Loading

The features works very well, good job!

I believe there is one case that you missed though. If the user clicks on the Collapse all button from the header of the page, the state of the objects is not saved, so a refresh of the page will reopen the previous state

This should be solved as of 5b80e3c

EDIT: Also see: 221980e

@hehoon hehoon marked this pull request as draft January 5, 2026 13:58
@graduta graduta closed this Jan 5, 2026
@graduta graduta reopened this Jan 5, 2026
@hehoon hehoon requested a review from graduta January 5, 2026 14:33
@hehoon hehoon marked this pull request as ready for review January 5, 2026 14:33
graduta
graduta previously approved these changes Jan 6, 2026
View reviewed changes
@hehoon hehoon requested a review from graduta January 6, 2026 15:50
@graduta graduta merged commit 0a6b618 into dev Jan 6, 2026
10 checks passed
@graduta graduta deleted the feature/QCG/OGUI-689/tree-stores-state-of-nodes-in-storage branch January 6, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graduta graduta graduta approved these changes

Assignees

@hehoon hehoon

Labels

Frontend Quality Control

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hehoon @graduta